Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partition: make ExchangePartition follow check constraints during writeOnly state(Part2) #46030

Merged
merged 20 commits into from
Sep 20, 2023
Merged

partition: make ExchangePartition follow check constraints during writeOnly state(Part2) #46030

merged 20 commits into from
Sep 20, 2023

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Aug 13, 2023 •
edited by mjonss
Loading

What problem does this PR solve?

Issue Number: ref #45922

Problem Summary:

What is changed and how it works?

Part2:
prohibiting insert or update records which not satisfy check constraints during ddl write only state.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 13, 2023

Hi @jiyfhust. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Aug 13, 2023

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust jiyfhust changed the title partition: make ExchangePartition follow check constraints during writeOnly state partition: make ExchangePartition follow check constraints during writeOnly state(Part2) Aug 13, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 20, 2023
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Aug 20, 2023 •
edited
Loading

/cc @mjonss
It is ready for review now.

@ti-chi-bot ti-chi-bot bot requested a review from mjonss August 20, 2023 12:21
@mjonss
Copy link
Contributor

mjonss commented Aug 21, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 21, 2023
mjonss
mjonss reviewed Aug 21, 2023
View reviewed changes
parser/model/model.go Outdated Show resolved Hide resolved
ddl/ddl_worker.go Outdated Show resolved Hide resolved
ddl/partition.go Outdated Show resolved Hide resolved
ddl/partition.go Outdated Show resolved Hide resolved
executor/write.go Outdated Show resolved Hide resolved
executor/write.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #46030 (6946446) into master (8b15111) will increase coverage by 0.0259%.
Report is 26 commits behind head on master.
The diff coverage is 70.6586%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #46030        +/-   ##
================================================
+ Coverage   73.0847%   73.1106%   +0.0259%     
================================================
  Files          1335       1358        +23     
  Lines        397994     409486     +11492     
================================================
+ Hits         290873     299378      +8505     
- Misses        88382      91478      +3096     
+ Partials      18739      18630       -109
Flag Coverage Δ
integration 30.9868% <4.1916%> (?)
unit 73.4888% <70.6586%> (+0.4040%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 85.3351% <ø> (+0.3478%) ⬆️
br 48.9527% <ø> (-3.9898%) ⬇️

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Sep 5, 2023

PTAL @mjonss

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2023
@jiyfhust
Copy link
Contributor Author

/retest

@jiyfhust
Copy link
Contributor Author

/retest

mjonss
mjonss reviewed Sep 13, 2023
View reviewed changes
parser/model/model.go Outdated Show resolved Hide resolved
ddl/partition.go Outdated Show resolved Hide resolved
ddl/rollingback.go Outdated Show resolved Hide resolved
executor/insert_common.go Show resolved Hide resolved
executor/write.go Show resolved Hide resolved
parser/model/model.go Outdated Show resolved Hide resolved
@jiyfhust
Copy link
Contributor Author

/retest

@mjonss
Copy link
Contributor

mjonss commented Sep 15, 2023

/retest

mjonss
mjonss approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 21:16:07.464602861 +0000 UTC m=+292933.432190896: ☑️ agreed by mjonss.
  • 2023-09-19 16:56:06.615233248 +0000 UTC m=+622932.582821298: ☑️ agreed by tiancaiamao.

@jiyfhust
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4edb78e into pingcap:master Sep 20, 2023
16 of 19 checks passed
@jiyfhust jiyfhust deleted the exchangepartition_check_part2 branch September 20, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiyfhust @mjonss @tiancaiamao